Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom climatology maps #1064

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Add support for custom climatology maps #1064

wants to merge 4 commits into from

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Feb 18, 2025 •
edited
Loading

The task ClimatologyMapCustom can be used to make climatology maps of 2D and 3D fields on cells, the latter with vertical dimension nVertLevels or nVertLevelsP1.

To support this, RemapDepthSlicesSubtask has been updated to support nVertLevelsP1 and a new utility function has been added to compute the z coordinate at layer interfaces.

Checklist

  • User's Guide has been updated
  • If this PR adds a new analysis task, it has also been added to the user's guide
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

@xylar
Copy link
Collaborator Author

xylar commented Feb 18, 2025

@irenavankova, this is the first of 2 features you requested. It seems to work, see:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis/v3.LR.piControl/clim_custom/ocean/index.html
(config options here https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis/v3.LR.piControl/clim_custom/v3.LR.piControl.cfg)

(Note: the web server has cached old versions of some plots. Hopefully, these will update again in a few hours.)

I need to:

  • add documentation
  • test on 2D fields
  • run the test suite (in progress)

In the meantime, give it a shot and let me know what you think. Happy to add more variables to defaults.cfg that you think might be useful.

@xylar xylar force-pushed the add-climatology-map-at-depths branch from 8b1cc7a to 297b92d Compare February 19, 2025 14:05
@xylar
Add ClimatologyMapCustom
8b904dc 
This analysis task supports a custom list of variables on cells
to be plotted at selected depths and on specified maps and over
the desired seasons.
@xylar xylar force-pushed the add-climatology-map-at-depths branch from 297b92d to 1dc9c35 Compare February 19, 2025 14:32
@xylar
Copy link
Collaborator Author

xylar commented Feb 19, 2025

Testing

Here are some update results showing both 2D and 3D fields, the latter with both nVertLevels and nVertLevelsP1 as the vertical dimension:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis/v3.LR.piControl/clim_custom/ocean/index.html

I have also successfully run the developer suite:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis_testing/chrysalis/add-climatology-map-at-depths/

@xylar xylar force-pushed the add-climatology-map-at-depths branch from 1dc9c35 to 53b43b8 Compare February 19, 2025 14:37
@xylar
Copy link
Collaborator Author

xylar commented Feb 19, 2025

I think this will be ready for review as soon as v1.13.0 get released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xylar